WebServer: use MD5Builder instead of mbedtls #8667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Jason2866
added a commit
to Jason2866/arduino-esp32
that referenced
this pull request
Jan 17, 2024
me-no-dev
pushed a commit
that referenced
this pull request
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
Checklist
This entire section above can be deleted if all items are checked.
Description of Change
Use ROM functions of the internal library instead of mbedtls implementation.
This reduces the binary size and removes an external dependency.
No functional changes.
Tests scenarios
Saves 20 bytes with example sketch in https://github.com/espressif/arduino-esp32/tree/master/libraries/WebServer/examples/HttpAdvancedAuth.
Test with Tasmota build (where this functionality is not used) was even more efficient with more than 100 bytes saved.